Skip to content

Update Cargo.toml to allow build under NetBSD#4349

Closed
ci4ic4 wants to merge 1 commit into
Hmbown:mainfrom
ci4ic4:patch-1
Closed

Update Cargo.toml to allow build under NetBSD#4349
ci4ic4 wants to merge 1 commit into
Hmbown:mainfrom
ci4ic4:patch-1

Conversation

@ci4ic4

@ci4ic4 ci4ic4 commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

rquickjs does not ship pre-generated bindings for NetBSD. Generate them.

Same true for FreeBSD, OpenBSD and DragonFly.

Summary

Testing

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets --all-features
  • cargo test --workspace --all-features

Checklist

  • Updated docs or comments as needed
  • Added or updated tests where relevant
  • Verified TUI behavior manually if UI changes
  • Harvested/co-authored credit uses a GitHub numeric noreply address

@ci4ic4
Update Cargo.toml
a8a5f4b 
rquickjs does not ship pre-generated bindings for NetBSD. Generate them.

Same true for FreeBSD, OpenBSD and DragonFly.
@ci4ic4 ci4ic4 requested a review from Hmbown as a code owner July 11, 2026 18:40
@github-actions

github-actions Bot commented Jul 11, 2026

Copy link
Copy Markdown

Thanks @ci4ic4 for taking the time to contribute.

This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered.

Please read CONTRIBUTING.md for the expected contribution shape. A maintainer can grant recurring PR access by commenting /lgtm on a pull request.

Hmbown pushed a commit that referenced this pull request Jul 12, 2026
@ci4ic4 @Hmbown
build(workflow-js): generate QuickJS bindings on NetBSD
b0a08ad 
rquickjs ships no pre-generated bindings for NetBSD, so the advertised
build fails trying to include a nonexistent bindings file. Enable the
bindgen feature for the NetBSD target, mirroring the Android arm
directly above. The explanatory comment is corrected from the Android
copy it was pasted from.

Harvested from PR #4349 by @ci4ic4
Co-authored-by: Chavdar Ivanov <6495973+ci4ic4@users.noreply.github.com>
Hmbown added a commit that referenced this pull request Jul 12, 2026
@Hmbown
docs(credit): record v0.8.68 underwater candidate and harvests
3eefeea 
Summarize the underwater interaction system, treatment/motion
independence, compact-room fixes, footer notice ownership, ASCII tier,
and localization parity work in the 0.8.68 changelog section, and credit
the harvested community work: Korean locale (PR #4347 @moduvoice),
Anthropic schema sanitization (PR #4346 @qinlinwang), Anthropic
cache-write pricing (PR #4348 @knqiufan), NetBSD bindgen (PR #4349
@ci4ic4), and the #4208 copy-pollution report (@eugenicum).
@github-actions

github-actions Bot commented Jul 12, 2026

Copy link
Copy Markdown

Thanks @ci4ic4 — your contribution landed in b0a08adc84c6 on main:

build(workflow-js): generate QuickJS bindings on NetBSD

Closing this PR now that the code is on main. Credit lives in the commit message and (where applicable) the CHANGELOG.md entry for the next release. Apologies for not closing this at the time of the merge — the auto-close workflow is new in v0.8.31.

If you want to land more work and would prefer your future PRs merge cleanly without a harvest step, the CONTRIBUTING.md doc has a short note on what makes a contribution mergeable as-is.

@github-actions github-actions Bot closed this Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hmbown Hmbown Awaiting requested review from Hmbown Hmbown is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ci4ic4